umeHack social
  • FAQ
  • Login
GNU social-nod för Umeå Hackerspace. Inbjudan krävs, men det är bara att hojta till oss om du vill vara med!
  • Public

    • Public
    • Groups
    • Popular
    • People

MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Saturday, 31-Jan-2015 17:36:00 CET

  1. MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Saturday, 31-Jan-2015 17:36:00 CET MMN-o ✅⃠ MMN-o ✅⃠
    • Roland Häder
    @roland@social.mxchange.org I really like that you're trying to apply better typing in the function calls etc. But I don't want everything at once. Could you do something like this and then request a merge?
    1. Find one function which you think should get stricter typing.
    2. Find all occurrences of that function (grep on the name)
    3. In all function definitions, add the type.
    4. In all function _calls_, make sure it really is that type (if it's one of the typical "sometimes user, sometimes profile", prefer to send a profile and convert by: $user->getProfile()).
    5. Verify that any of the "converted from user to profile" changes in the previous step don't have User-class specific calls (like ->streamModeOnly or a property like ->email). In that case, revert back to a user with $profile->getUser();

    ...and do this for _one_ function call at a time. Since when I have to verify all the changes, I don't want to track multiple calls in the same issue.
    In conversation Saturday, 31-Jan-2015 17:36:00 CET from web permalink

Feeds

  • Activity Streams
  • Atom
  • Help
  • About
  • FAQ
  • TOS
  • Privacy
  • Source
  • Version
  • Contact

umeHack social is a social network, courtesy of Umeå Hackerspace. It runs on GNU social, version 1.2.0-beta5, available under the GNU Affero General Public License.

Creative Commons Attribution 3.0 All umeHack social content and data are available under the Creative Commons Attribution 3.0 license.