MMN-o ✅⃠ (mmn@social.umeahackerspace.se)'s status on Saturday, 31-Jan-2015 17:36:00 CET
-
@roland@social.mxchange.org I really like that you're trying to apply better typing in the function calls etc. But I don't want everything at once. Could you do something like this and then request a merge?
1. Find one function which you think should get stricter typing.
2. Find all occurrences of that function (grep on the name)
3. In all function definitions, add the type.
4. In all function _calls_, make sure it really is that type (if it's one of the typical "sometimes user, sometimes profile", prefer to send a profile and convert by: $user->getProfile()).
5. Verify that any of the "converted from user to profile" changes in the previous step don't have User-class specific calls (like ->streamModeOnly or a property like ->email). In that case, revert back to a user with $profile->getUser();
...and do this for _one_ function call at a time. Since when I have to verify all the changes, I don't want to track multiple calls in the same issue.